[Doc] Add more examples of adding attributes in Live Components #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It only works with attributes in a toggle way .. you may want to use addClass there i think |
|
Thanks for the review. I updated the PR to show an example that won't work and explain that explicitly. Thanks. |
smnandre
approved these changes
Feb 23, 2024
carsonbot
added
Status: Reviewed
kbond
reviewed
Feb 23, 2024
weaverryan
added
Status: Needs Work
weaverryan
requested changes
Feb 27, 2024
|
Sorry I forgot about this PR. I did all the changes that you suggested. Thanks for the reviews! |
@javiereguiluz, did you miss pushing these changes? |
javiereguiluz
force-pushed
the
doc-add-attribute
branch
from
6c1eb52 to
46c4836
Compare
carsonbot
added
Status: Needs Review
|
@kbond yes, sorry 😊 |
kbond
approved these changes
Feb 28, 2024
carsonbot
added
Status: Reviewed
weaverryan
force-pushed
the
doc-add-attribute
branch
from
46c4836 to
a6f2fe6
Compare
|
Thanks Javier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I tried this in a Symfony app and it didn't work ... so I'm opening this PR to ask you if this should work or if
addAttribute()is only for empty attributes that don't define a value.Thanks!