Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] fix: hide IconSearchBox on mobile when AppHeader is open #1716

Conversation

raphael-geffroy
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Issues Fix #...
License MIT

(Issue 1711 - 3)
When the AppHeader in the icon page on mobile the IconSearchBox is undesirably visible. This PR aims to hide it.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 10, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 10, 2024
@raphael-geffroy raphael-geffroy changed the title fix: hide IconSearchBox on mobile when AppHeader is open [Site] fix: hide IconSearchBox on mobile when AppHeader is open Apr 10, 2024
@kbond
Copy link
Member

kbond commented Apr 10, 2024

Thanks for this great first PR @raphael-geffroy!

@kbond kbond merged commit 83fa9a4 into symfony:2.x Apr 10, 2024
1 check passed
@raphael-geffroy
Copy link
Contributor Author

Actually that's the second ! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants