[Site] refactor commonmark config #1791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
site/commonmark-refactor
branch
from
a883b9f to
9e6cedb
Compare
kbond
force-pushed
the
site/commonmark-refactor
branch
from
9e6cedb to
4493319
Compare
Wow !
❤️ |
smnandre
reviewed
Apr 26, 2024
smnandre
approved these changes
Apr 26, 2024
carsonbot
added
Status: Reviewed
smnandre
approved these changes
Apr 26, 2024
Kocal
reviewed
Apr 26, 2024
| ]); | ||
|
|
||
| $converter->getEnvironment() | ||
| ->addRenderer(FencedCode::class, new CodeRenderer(), 10) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to add commonmark configuration to the extensions. Also, I refactored the Changelog to use native commonmark extension for github mentions/issue links (fixes a few bugs too).