Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stimulus] Use Twig >3.9 'EscaperRuntime' #1824

Merged
merged 1 commit into from
May 8, 2024
Merged

[Stimulus] Use Twig >3.9 'EscaperRuntime' #1824

merged 1 commit into from
May 8, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented May 3, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Resolves CI deprecations (for > Twig 3.9)

Twig introduction of EscaperRuntime here: twigphp/Twig#4055

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label May 3, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 4, 2024
WebMamba
WebMamba reviewed May 4, 2024
View reviewed changes
Copy link
Collaborator

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum wait the test fail for php8.3, so it look like the current fix is not take into account

@smnandre
Copy link
Member Author

smnandre commented May 5, 2024

This fixes the deprecation in the Stimulus bundle .. the remaining must be fixed within the remaining component.

And i try to avoid PR acting on multiple components at once

WebMamba
WebMamba approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok perfect then!

@kbond
Copy link
Member

kbond commented May 8, 2024

Thanks Simon.

@kbond kbond merged commit 5e4ba9f into symfony:2.x May 8, 2024
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebMamba WebMamba WebMamba approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smnandre @kbond @WebMamba @carsonbot