Skip to content

Conversation

cavasinf
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Issues Fix #1704
License MIT

Fixes the missing doc part as discussed in #1704

@cavasinf cavasinf changed the title [LiveComponent] Update DOC preMount validation data code [TwigComponent] Update DOC preMount validation data code May 13, 2024
Copy link
Contributor

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: some sugestion to make syntax a bit shorter to improver readability

Copy link
Contributor

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cavasinf! Documenting is key, and this PR make think much more clear!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 15, 2024
@kbond
Copy link
Member

kbond commented May 15, 2024

Excellent, thank you Florian!

@kbond kbond merged commit 416753f into symfony:2.x May 15, 2024
@cavasinf cavasinf deleted the patch-1 branch May 16, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LiveComponent Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TwigComponent] Missleading doc between Passing & Rendering Attributes and PreMount validation
5 participants