chore: check if fabbot is correctly working #2014
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Bug
|
|
|
fabbot is green when it's supposed to be red, the code here is not valid (run PHP-CS-Fixer locally and see the diff). But I'm already seeing this problem with Fabien! |
|
(side topic: if we also could make a global pass with fabbot, to fix all the exceptions format at once, that'd be great) |
kbond
added a commit
that referenced
this pull request
Aug 20, 2024
This PR was merged into the 2.x branch. Discussion ---------- chore: run PHP-CS-Fixer | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Fabbot still misses our PHP-CS-Fixer configuration (tracked in #2014) :( Commits ------- 1420976 chore: run PHP-CS-Fixer
|
Okay, here fabbot is working as expected: Closing for now, let's observe other PR 👀 |
Kocal
added a commit
that referenced
this pull request
May 31, 2025
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [CI] Re-add PHP-CS-Fixer | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Follow #2802, #2074, #2014 and more. I feel like Fabbot **only runs on modified files** for a given PR, but sometimes it does not really help (e.g.: if you untouched files contain old references to a deleted class). This behavior is understandable for symfony/symfony, which contains a tons of code and is super active, but that's not the case symfony/ux, we have very less code and less activity. **EDIT:** Well, I'm still not sure... PHP-CS-Fixer is showing me fixes for `src/LiveComponent/src/Util/TypeHelper.php`, added in #2778, but it was totally ignored by Fabbot... 😫 So, I suggest to re-add PHP-CS-Fixer run in the CI to ensure all files are correctly CS-fixed. Commits ------- 1ab48b6 [CI] Re-add PHP-CS-Fixer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR opened for Fabien.
Following #1996, we need to understand if something is wrong with fabbot or not.
⚠️ This PR should not be merged!