[Site] UX Map page #2053
Merged
[Site] UX Map page #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
approved these changes
Aug 13, 2024
carsonbot
added
Status: Reviewed
kbond
added a commit
that referenced
this pull request
Aug 13, 2024
…an fails on some projects (Kocal) This PR was merged into the 2.x branch. Discussion ---------- [Map][Leaflet] Fix marker icon gradients rendering, which can fails on some projects | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Another fix for UX Map, but for the better. I didn't have this issue at all when working on UX Map implementation (on my "lab" project or on my personal website), but `@smnandre` got it when working on #2053: <img width="1234" alt="Capture d’écran 2024-08-13 à 10 32 08" src="https://github.com/user-attachments/assets/4ebf9c4f-004c-4890-a429-0609c6ab5a46"> It looks like over-optimizing the SVG through https://jakearchibald.github.io/svgomg/, the `id` attributes optimization brokes the rendering. Using another `id` specific for UX Map fixes the issue: <img width="1193" alt="Capture d’écran 2024-08-13 à 10 33 36" src="https://github.com/user-attachments/assets/8cb82515-7896-481a-94fb-a223a4fc245b"> Commits ------- 44e4b20 [Map][Leaflet] Fix marker icon gradients rendering, which can fails on some projects
smnandre
force-pushed
the
site/ux-map
branch
4 times, most recently
from
d577168 to
0c2257c
Compare
carsonbot
added
Status: Needs Review
carsonbot
added
Status: Reviewed
|
Thanks Simon. |
kbond
added a commit
that referenced
this pull request
Aug 15, 2024
…Kocal) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [ux.symfony.com] Fix rendering/color issues on Map page | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> It looks like we have some visual issues in light mode on the Map page, we can't see the menu: <img width="1501" alt="Capture d’écran 2024-08-15 à 07 42 21" src="https://github.com/user-attachments/assets/6a39c912-3cc3-4b73-82a5-16a5aa751d1e"> And we miss the `composer require ...` thing. I've Replaced the usage of the new component `Hero` (introduced in #2053) by the good old `PackageHeader` component. This is the quickest solution right now to correctly render UX Map page, and it gives us some times to improve this `Hero` component and re-use it in all UX package pages. **EDIT:** I've seen with `@smnandre` for some minor adjustements: <img width="1512" alt="image" src="https://github.com/user-attachments/assets/8544f46a-37aa-4b1e-964e-380174a2d0c5"> <img width="1510" alt="image" src="https://github.com/user-attachments/assets/b7617ebe-f014-4e50-a3b3-c78f5045b552"> Commits ------- c3a8806 [ux.symfony.com] Fix rendering/color issues on Map page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(very simple page for now, but i'd like to deploy a page asap... and then we'll have more time for demos, docs...)
Closes #2042