Skip to content

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Sep 20, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Before:

Enregistrement.de.l.ecran.2024-09-20.a.09.49.54.mov

After:

Enregistrement.de.l.ecran.2024-09-20.a.09.52.26.mov

@carsonbot carsonbot added Site ux.symfony.com Status: Needs Review Needs to be reviewed labels Sep 20, 2024
@@ -1,6 +1,6 @@
{% macro summaryAttributes(description) %}
{% if description %}
data-bs-toggle="tooltip" data-bs-html="true" data-bs-placement="auto" title="{{ description|e('html_attr') }}"
data-bs-toggle="tooltip" data-bs-html="true" data-bs-placement="right" title="{{ description|e('html_attr') }}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required for the fix, but it was more friendly

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks better.

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 20, 2024
@Kocal Kocal merged commit 4705d03 into symfony:2.x Sep 20, 2024
3 of 4 checks passed
@Kocal Kocal deleted the site-fix-homepage-tooltips branch September 20, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site ux.symfony.com Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants