[TwigComponent][Docs] Fix outerblock markup example#2235
Merged
Kocal merged 1 commit intosymfony:2.xfrom Oct 5, 2024
Merged
Conversation
Member
With your fix it's more logic :) |
Kocal
approved these changes
Oct 5, 2024
Member
|
Thank you @tobiasberge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was following the guide for nested UX components and inheritance. Really cool stuff. 👍
Inheritance & Forwarding "Outer Blocks"
I was confused about this code example that re-uses the alert component and "passes through" the content text from the
SuccessAlertcomponent usage:Is it really supposed to be two nested alert components? Because this throws an error because of the missing
{% endcomponent %}tag.Should it be either this...
or this syntax?