[Meta] Replace CleanCSS by LightningCSS#2429
Merged
Merged
Conversation
Contributor
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||||||||||||||
Kocal
force-pushed
the
meta-replace-clean-css-by-lightning-css
branch
from
b9dcde3 to
3f2e4f4
Compare
Kocal
changed the title
smnandre
reviewed
Dec 10, 2024
| @@ -1 +1 @@ | |||
| [data-loading=""],[data-loading="delay|show"],[data-loading=show]{display:none} No newline at end of file | |||
| [data-loading=""],[data-loading=show],[data-loading=delay\|show]{display:none} No newline at end of file | |||
Member
There was a problem hiding this comment.
@Kocal Not sure about that... and we may want to discuss this kind of thing together 😅
smnandre
reviewed
Dec 10, 2024
| @@ -1 +1 @@ | |||
| .toggle-password-container{position:relative}.toggle-password-icon{height:1rem;width:1rem}.toggle-password-button{align-items:center;background-color:transparent;border:none;column-gap:.25rem;display:flex;flex-direction:row;font-size:.875rem;justify-items:center;height:1rem;line-height:1.25rem;position:absolute;right:.5rem;top:-1.25rem} No newline at end of file | |||
| .toggle-password-container{position:relative}.toggle-password-icon{width:1rem;height:1rem}.toggle-password-button{background-color:#0000;border:none;flex-direction:row;place-items:center;column-gap:.25rem;height:1rem;font-size:.875rem;line-height:1.25rem;display:flex;position:absolute;top:-1.25rem;right:.5rem} No newline at end of file | |||
smnandre
reviewed
Dec 10, 2024
| "@symfony/stimulus-testing": "^2.0.1", | ||
| "@vitest/browser": "^2.1.1", | ||
| "clean-css": "^5.3.3", | ||
| "lightningcss": "^1.28.2", |
Member
There was a problem hiding this comment.
+1 for the change
-1 for the hurry 😅
smnandre
reviewed
Dec 10, 2024
| filename: path.basename(inputStyleFile, '.css'), | ||
| code: Buffer.from(css), | ||
| minify: true, | ||
| sourceMap: false, // TODO: Maybe we can add source maps later? :) |
Member
There was a problem hiding this comment.
Source Maps have more interest when there is multiple source files, variables, etc.. not the case here.
But if we have a component offering CSS, why not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more step to modernize our build stack, by replacing https://github.com/clean-css/clean-css by https://lightningcss.dev/.
TBH it does not bring a lot of value since we only have 4 very small CSS files, buuuut that's for a better future :) (#rolldown)