[Autocomplete] Fix Incompatibility filter_query and max_results (doc)

[ytilotti]

Q	A
Bug fix?	no
New feature?	no
Issues	Fix #769
License	MIT

Fix in the documentation the incompatibility between filter_query and max_results.

[carsonbot]

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

[smnandre]

Nice catch here!

Would you also update the BaseAutocompleteType code to make the same check than filter/searcheable_fields ?

ux/src/Autocomplete/src/Form/BaseEntityAutocompleteType.php

Lines 68 to 75 in eab7db5

	$resolver->setAllowedTypes('filter_query', ['callable', 'null']);
	$resolver->setNormalizer('searchable_fields', function (Options $options, ?array $searchableFields) {
	if (null !== $searchableFields && null !== $options['filter_query']) {
	throw new RuntimeException('Both the searchable_fields and filter_query options cannot be set.');
	}
	return $searchableFields;
	});

[ytilotti]

Can be a problem because max_results has default to 10.

[smnandre]

Well let's forget then :) Thanks for the fix!

[smnandre]

Thank you @ytilotti.