[LiveComponent] Allow configuring secret for fingerprints and checksums#2462
Conversation
Kocal
left a comment
There was a problem hiding this comment.
It's an interesting approach, are there any plans to open a PR on symfony/recipes?
|
Not at all, why? |
|
Is there any considerations we need to make regarding: https://symfony.com/blog/new-in-symfony-7-2-optional-secret ? |
|
@kbond I don't think so, if i understand this correctly
But that's one of the reasons this PR checks for empty secrets: #2461) |
For pure user-DX, I believe creating recipes with commented/default options is nice to have |
|
This would be the only options for the live_component package.. so i'm not sure we want to annoy existing apps with a new file for this only.. it's more a power-user to me and can lead to very bad/insecure choices :| I guess this is something we will do easier when centralized (at least a bit) in UX Bundle |
|
Makes sense, thanks! :) |
339ef20 to
a641a2e
Compare
Allow to configure a dedicated secret (used in FingerprintCalculator and LiveComonentHydrator)
Suggested by @dkarlovi in #2453
Implementation inspired by symfony #56840
Should be merged after #2461