[Site] Visual improvments on IconModal #2465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super nice! Well done it looks perfect! (i'm so focus on the "next" website i tend to forget to fix things on the current one .. 🫨 ) Just: did you check in dark mode ? |
DW, you are doing well! :)
Oh, I forgot about it, but yes it looks nice: |
carsonbot
added
Status: Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lightskycolor was hard to read on a grey background, I changed it to the Bootstrap code color and it is better (it still does not pass accessibility tests, but that's better). I also changed the activeTabbackground-color:On mobile, or resized window, opening and use the
IconModalwas not convenient, so I adapted it: