[Autocomplete] Rethrow BadRequestHttpException in case of malformed extra_options
#2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Autocomplete
Bug
smnandre
reviewed
Feb 24, 2025
src/Autocomplete/src/Controller/EntityAutocompleteController.php
Outdated
Show resolved
Hide resolved
smnandre
approved these changes
Feb 24, 2025
carsonbot
added
Status: Reviewed
… `extra_options`
norkunas
force-pushed
the
autocomplete-extraoptions-decode
branch
from
17bb6af to
e59554a
Compare
|
Thank you @norkunas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's enough just to manually edit extra_options in URL to a random string and then get a 500 error while polluting logs. I think it's better to swallow it and properly exit with 400 status.