Skip to content

[LiveComponent] Add uid support for hydration #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

[LiveComponent] Add uid support for hydration #2654

merged 1 commit into from
Apr 16, 2025

Conversation

norkunas
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Docs? no
Issues N/A
License MIT

I think it's a common use case, I encountered this many times already..

@carsonbot carsonbot added Feature New Feature LiveComponent Status: Needs Review Needs to be reviewed labels Mar 24, 2025
Kocal
Kocal requested changes Mar 25, 2025
View reviewed changes
Copy link
Member

@Kocal Kocal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, and indeed, it makes sense.
Just a few comments :)

@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Mar 25, 2025
@norkunas norkunas force-pushed the livecomponent-uid branch from 6642c31 to d043cc2 Compare March 26, 2025 04:50
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Mar 26, 2025
smnandre
smnandre approved these changes Mar 30, 2025
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @norkunas: small yet very cool addition! 👍

Good for me when @Kocal is ok

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 30, 2025
kbond
kbond approved these changes Apr 15, 2025
View reviewed changes
@norkunas norkunas force-pushed the livecomponent-uid branch from d043cc2 to e115bf3 Compare April 16, 2025 04:24
@Kocal
Copy link
Member

Kocal commented Apr 16, 2025

Sorry for the delay, I wasn't confident enough to merge it blindly.
I've tested your branch locally and things work as expected!

@Kocal
Copy link
Member

Kocal commented Apr 16, 2025

Thanks @norkunas.

@Kocal Kocal merged commit 26ed9f1 into symfony:2.x Apr 16, 2025
76 of 79 checks passed
@norkunas norkunas deleted the livecomponent-uid branch April 16, 2025 06:59
@smnandre smnandre mentioned this pull request May 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

@smnandre smnandre smnandre approved these changes

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Feature New Feature LiveComponent Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@norkunas @Kocal @kbond @smnandre @carsonbot