[Turbo] Pass turbo_stream_listen topics to mercure if not defined - #2694
Merged
Conversation
Fan2Shrek
force-pushed
the
optimise-turbo_stream_listen
branch
2 times, most recently
from
April 14, 2025 19:51
8a9cd1c to
c5fc9fb
Compare
smnandre
reviewed
Apr 15, 2025
Fan2Shrek
force-pushed
the
optimise-turbo_stream_listen
branch
from
April 15, 2025 06:13
c5fc9fb to
f556d2a
Compare
Kocal
approved these changes
Apr 16, 2025
carsonbot
added
Status: Reviewed
smnandre
approved these changes
Apr 17, 2025
Member
|
Thanks @Fan2Shrek. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the documentation says:
"If you're using a private hub, you can add { withCredentials: true } as the third argument to turbo_stream_listen() to authenticate with the hub."However, this doesn’t actually work because the cookie is not created.
See: MercureExtension.php#L75
To make it work, we need to explicitly specify the topics again. The working call looks like this:
turbo_stream_listen("topics", "default", { subscribe: 'topics', withCredentials: true }So I updated the implementation, adding the
subscribekey if it's not already defined.My mistake, sorry 😅