[Toolkit] Add functional tests to render all Kit components usage codes (from their documentation), with a snapshot system - #2720
Merged
Conversation
carsonbot
added
Feature
Kocal
commented
May 8, 2025
Kocal
commented
May 8, 2025
Kocal
commented
May 8, 2025
Kocal
force-pushed
the
toolkit/test-func-docs-code-examples
branch
3 times, most recently
from
May 8, 2025 12:35
e861af1 to
eb81e37
Compare
…es (from their documentation), with a snapshot system
…og (will be re-added later 😇)
Kocal
force-pushed
the
toolkit/test-func-docs-code-examples
branch
from
May 8, 2025 12:55
eb81e37 to
1b1c545
Compare
…ra on PHP < 8.2, since it now supports PHP 8.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add snapshots testing for each Twig code blocks from
src/Toolkit/kits/**/docs/components/*.md, to ensure that rendering is always good.I don't think we will add visual testing, at least for now. Having snapshots tests and visual previews (on the website) feels convenient enough, but if someone has a super-simple solution, why not!)
I tagged the PR as a feature, not because the snapshots testing itself, but because I introduced a new service
KitContextRunner. I needed something similar than the "hacks" from the website, but for tests.