Skip to content

Conversation

smnandre
Copy link
Member

Improves Parser exception

Throw a SyntaxError instead of a LogicError in ComponentParser

(following Twig #4601 : twigphp/Twig#4601)

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label May 11, 2025
@smnandre
Copy link
Member Author

(failures unrelated, PR already opened to handle them)

@smnandre smnandre requested review from kbond and Kocal May 11, 2025 23:04
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 12, 2025
@Kocal Kocal force-pushed the twig/improve-exception-parser branch from 0f07a28 to 55f8d64 Compare May 23, 2025 09:31
@Kocal
Copy link
Member

Kocal commented May 23, 2025

Thank you @smnandre.

@Kocal Kocal merged commit 0cf3a6d into symfony:2.x May 23, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants