-
-
Notifications
You must be signed in to change notification settings - Fork 376
Remove ComponentAttributeFactory and inject EscaperRuntime directly #2749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very few comments, otherwise it looks nice to me 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplicity FTW 🚀
just minor comments to fix before merge
(remaining fabbot failures unrelated / false positives) |
eef2738
to
13755d9
Compare
Thank you @smnandre. |
Is it expected that |
Thanks |
Replaces the
ComponentAttributesFactory
with direct usage of theEscaperRuntime
from TwigInject
EscaperRuntime
inComponentAttributes
ComponentAttributesFactory
withTwig\Environment
andEscaperRuntime
inAddLiveAttributesSubscriber
,LiveComponentHydrator
, andChildComponentPartialRenderer
, ensuringComponentAttributes
is instantiated with the necessaryEscaperRuntime
.ComponentAttributes
constructor to requireEscaperRuntime
directly, removing the deprecatedHtmlAttributeEscaperInterface
.Remove
ComponentAttributeFactory
ComponentAttributesFactory
and its related logic across the codebaseComponentAttributesFactory
Dependency Updates
symfony/ux-twig-component
dependency incomposer.json
to version^2.25.1
Documentation Updates
CHANGELOG.md
for version2.25.1