[Map] add definition to after create events in controller - #2763
Merged
Conversation
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
Contributor
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||||||||||||||
carsonbot
added
Status: Reviewed
Kocal
requested changes
May 23, 2025
| this.dispatchEvent(eventBefore, { definition }); | ||
| const drawing = factory({ definition }); | ||
| this.dispatchEvent(eventAfter, { [type]: drawing }); | ||
| this.dispatchEvent(eventAfter, { [type]: drawing, definition: definition }); |
Member
There was a problem hiding this comment.
Since I can't push on your repository, you will need to do the following changes:
- This change must be done in the
src/abstract_map_controller.tsfile - You also need to update the
info-window:after-createevent - finally, you have to rebuild the dist files (https://github.com/symfony/ux/blob/2.x/CONTRIBUTING.md#working-with-assets)
Thanks!
carsonbot
added
Status: Needs Work
carsonbot
added
Status: Needs Review
Kocal
approved these changes
May 23, 2025
carsonbot
added
Status: Reviewed
Member
|
Thanks @mart-insiders and @dannyvw :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The documentationstates that the definition should be accessible in the :after-create events in the map controllers.