Skip to content

[Icons] Docs: Some typos#2781

Merged
Kocal merged 1 commit into
symfony:2.xfrom
ThomasLandauer:patch-2
May 29, 2025
Merged

[Icons] Docs: Some typos#2781
Kocal merged 1 commit into
symfony:2.xfrom
ThomasLandauer:patch-2

Conversation

@ThomasLandauer

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? no
Docs? yes
Issues
License MIT

Page: https://symfony.com/bundles/ux-icons/current/index.html

@carsonbot carsonbot added Icons Status: Needs Review Needs to be reviewed labels May 28, 2025
Comment thread src/Icons/doc/index.rst

That's all. This works by using the `Iconify`_ API (to which `ux.symfony.com/icons`_
is a frontend for) to fetch the icon and render it in place. This icon is then cached
is a frontend) to fetch the icon and render it in place. This icon is then cached

@Kocal Kocal May 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super-fluent in english, but to me the previous version sounds better, no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just switch the parts:

ux.symfony.com/icons is a frontend for the the Iconify API

=> OK

ux.symfony.com/icons is a frontend to the the Iconify API

=> OK

ux.symfony.com/icons is a frontend to for the the Iconify API

=> Not OK

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 28, 2025
@Kocal Kocal added the Documentation Improvements or additions to documentation label May 28, 2025

@smnandre smnandre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! Thanks!

@Kocal

Kocal commented May 29, 2025

Copy link
Copy Markdown
Member

Thank you @ThomasLandauer.

@Kocal Kocal merged commit 8f02bd6 into symfony:2.x May 29, 2025
2 checks passed
@ThomasLandauer ThomasLandauer deleted the patch-2 branch May 29, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Icons Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants