Skip to content

[Autocomplete] Upgrade Foundry to ^2.0 #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jul 17, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #...
License MIT

Minor work to upgrade Foundry 1.37.* to ^2.0 on Autocomplete, and remove some Foundry deprecations (also applied to LiveComponent)

@Kocal Kocal force-pushed the autocomplete-upgrade-foundry-2.x branch 3 times, most recently from 4926488 to b1ee848 Compare July 17, 2025 07:02
@Kocal Kocal changed the title [Autocomplete] Upgrade Foundry to ^2.6 [Autocomplete] Upgrade Foundry to ^2.0 Jul 17, 2025
@Kocal Kocal force-pushed the autocomplete-upgrade-foundry-2.x branch from b1ee848 to a1071a0 Compare July 17, 2025 07:04
@Kocal Kocal force-pushed the autocomplete-upgrade-foundry-2.x branch from a1071a0 to 5160681 Compare July 17, 2025 07:06
@Kocal
Copy link
Member Author

Kocal commented Jul 17, 2025

Not related, but we still need to find why it's happening in PHP 8.4 https://github.com/symfony/ux/actions/runs/16338540569/job/46155434915?pr=2928#step:9:1042 :

1) Symfony\UX\Autocomplete\Tests\Functional\AutocompleteFormRenderingTest::testFieldsRenderWithStimulusController
RuntimeException: Unable to create the Doctrine Proxy directory "". in /home/runner/work/ux/ux/src/Autocomplete/vendor/symfony/doctrine-bridge/CacheWarmer/ProxyCacheWarmer.php:49
Stack trace:
#0 /home/runner/work/ux/ux/src/Autocomplete/vendor/symfony/http-kernel/CacheWarmer/CacheWarmerAggregate.php(96): Symfony\Bridge\Doctrine\CacheWarmer\ProxyCacheWarmer->warmUp()
#1 /home/runner/work/ux/ux/src/Autocomplete/vendor/symfony/http-kernel/Kernel.php(546): Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerAggregate->warmUp()
#2 /home/runner/work/ux/ux/src/Autocomplete/vendor/symfony/http-kernel/Kernel.php(744): Symfony\Component\HttpKernel\Kernel->initializeContainer()
#3 /home/runner/work/ux/ux/src/Autocomplete/vendor/symfony/http-kernel/Kernel.php(120): Symfony\Component\HttpKernel\Kernel->preBoot()
#4 /home/runner/work/ux/ux/src/Autocomplete/vendor/symfony/framework-bundle/Test/KernelTestCase.php(75): Symfony\Component\HttpKernel\Kernel->boot()
#5 /home/runner/work/ux/ux/src/Autocomplete/vendor/zenstruck/foundry/src/Test/ResetDatabase.php(36): Symfony\Bundle\FrameworkBundle\Test\KernelTestCase::bootKernel()
#6 /home/runner/work/ux/ux/src/Autocomplete/vendor/zenstruck/foundry/src/Persistence/ResetDatabase/ResetDatabaseManager.php(51): Symfony\UX\Autocomplete\Tests\Functional\AutocompleteFormRenderingTest::{closure:Zenstruck\Foundry\Test\ResetDatabase::_resetDatabaseBeforeFirstTest():36}()
#7 /home/runner/work/ux/ux/src/Autocomplete/vendor/zenstruck/foundry/src/Test/ResetDatabase.php(35): Zenstruck\Foundry\Persistence\ResetDatabase\ResetDatabaseManager::resetBeforeFirstTest()
#8 /home/runner/work/ux/ux/src/Autocomplete/vendor/bin/.phpunit/phpunit-9.6-0/src/Framework/TestSuite.php(629): Symfony\UX\Autocomplete\Tests\Functional\AutocompleteFormRenderingTest::_resetDatabaseBeforeFirstTest()
#9 /home/runner/work/ux/ux/src/Autocomplete/vendor/bin/.phpunit/phpunit-9.6-0/src/Framework/TestSuite.php(685): PHPUnit\Framework\TestSuite->run()
#10 /home/runner/work/ux/ux/src/Autocomplete/vendor/bin/.phpunit/phpunit-9.6-0/src/Framework/TestSuite.php(685): PHPUnit\Framework\TestSuite->run()
#11 /home/runner/work/ux/ux/src/Autocomplete/vendor/bin/.phpunit/phpunit-9.6-0/src/TextUI/TestRunner.php(651): PHPUnit\Framework\TestSuite->run()
#12 /home/runner/work/ux/ux/src/Autocomplete/vendor/bin/.phpunit/phpunit-9.6-0/src/TextUI/Command.php(146): PHPUnit\TextUI\TestRunner->run()
#13 /home/runner/work/ux/ux/src/Autocomplete/vendor/bin/.phpunit/phpunit-9.6-0/src/TextUI/Command.php(99): PHPUnit\TextUI\Command->run()
#14 /home/runner/work/ux/ux/src/Autocomplete/vendor/bin/.phpunit/phpunit-9.6-0/phpunit(22): PHPUnit\TextUI\Command::main()
#15 /home/runner/work/ux/ux/src/Autocomplete/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php(478): include('...')
#16 /home/runner/work/ux/ux/src/Autocomplete/vendor/symfony/phpunit-bridge/bin/simple-phpunit(13): require('...')
#17 /home/runner/work/ux/ux/src/Autocomplete/vendor/bin/simple-phpunit(119): include('...')
#18 {main}

Surely we are missing some configuration

@Kocal Kocal merged commit 2e2e3e8 into symfony:2.x Jul 17, 2025
22 of 25 checks passed
@Kocal Kocal deleted the autocomplete-upgrade-foundry-2.x branch July 21, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants