[LiveComponent] Some fixes on JS dependencies assets#2940
Merged
Conversation
Kocal
commented
Jul 25, 2025
Comment on lines
-47
to
-49
| "dependencies": { | ||
| "idiomorph": "^0.3.0" | ||
| }, |
Member
Author
There was a problem hiding this comment.
To resume, since idiomorph is inlined in our dist files and there is no more import ... from 'idiomorh' in them, then there is no point to make it a prod dependency, it should be a dev dependency instead.
Kocal
force-pushed
the
tweak-live-components-assets
branch
from
July 25, 2025 06:54
501736d to
c3be957
Compare
Kocal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing some incoherent things found in #2935, each commit are separated and contains a link to the comment explaing why