Skip to content

[Autocomplete][Chartjs][Cropperjs][Dropzone][Icons][LazyImage][LiveComponent][Map][Notify][React][StimulusBundle][Svelte][Swup][TogglePassword][Toolkit][Translator][Turbo][TwigComponent][Typed][Vue] Add support for Symfony 8 #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Aug 5, 2025

Q A
Bug fix? no
New feature? yes
Docs? no
Issues Fix #...
License MIT

As suggested in symfony/webpack-encore-bundle#248, I added new jobs for testing explicit Symfony version.

The Symfony 8.0.x-dev job is failing because it needs zenstruck/foundry#891, which is not possible to use because Foundry is not compatible with Symfony 8 yet (opened zenstruck/foundry#960)

There is a lot of changes, but these are only small modifications (composer.json, CHANGELOG.md, and fixing method typings)

I also updated the deprecated packages, that's fine, it makes things easier for us to handle

@Kocal Kocal force-pushed the symfony-8-support branch from e7a0922 to 3012a2f Compare August 5, 2025 12:37
@Kocal Kocal marked this pull request as ready for review August 5, 2025 12:37
@carsonbot carsonbot added Feature New Feature Status: Needs Review Needs to be reviewed labels Aug 5, 2025
@Kocal Kocal force-pushed the symfony-8-support branch 19 times, most recently from 8b9d4f3 to 240a6ed Compare August 5, 2025 22:01
@Kocal Kocal force-pushed the symfony-8-support branch from 240a6ed to 998de8d Compare August 5, 2025 22:04
"symfony/twig-bundle": "^5.4|^6.0|^7.0",
"symfony/webpack-encore-bundle": "^1.15"
"symfony/twig-bundle": "^5.4|^6.0|^7.0|^8.0",
"symfony/webpack-encore-bundle": "^1.15|^2.3.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We (dev) require WebpackEncoreBundle to ensure compability with the old AbstractStimulusDto class.

This class does not exist anymore in WebpackEncoreBundle ^2, but upgrading it here allows TwigComponent to be installed with Symfony 8.0, since WebpackEncoreBundle ^1.6 does not support Symfony 8.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is to remove it in UX 3.x

@carsonbot carsonbot changed the title Add support for Symfony 8 [Autocomplete][Chartjs][Cropperjs][Dropzone][Icons][LazyImage][LiveComponent][Map][Notify][React][StimulusBundle][Svelte][Swup][TogglePassword][Toolkit][Translator][Turbo][TwigComponent][Typed][Vue] Add support for Symfony 8 Aug 6, 2025
@Kocal Kocal merged commit 2aceea8 into symfony:2.x Aug 6, 2025
33 of 36 checks passed
@Kocal Kocal deleted the symfony-8-support branch August 7, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants