Repository navigation
[Vue] Update dev dependency @vitejs/plugin-vue - #2977
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the @vitejs/plugin-vue dependency to address security vulnerabilities in the esbuild dependency chain. The change upgrades the plugin from version ^4.4.0 to ^5.1.5 to ensure compatibility with Vite 6+ which requires esbuild 0.25.0+ to resolve known security issues.
- Updates
@vitejs/plugin-vuefrom ^4.4.0 to ^5.1.5 in package.json
| "@testing-library/user-event": "^14.6.1", | ||
| "@types/webpack-env": "^1.16", | ||
| "@vitejs/plugin-vue": "^4.4.0", | ||
| "@vitejs/plugin-vue": "^5.1.5", |
There was a problem hiding this comment.
This is a major version upgrade (4.x to 5.x) that may introduce breaking changes. Consider reviewing the plugin-vue migration guide and testing thoroughly to ensure compatibility with existing Vue components and build configurations.
Kocal
left a comment
There was a problem hiding this comment.
Thanks for the PR!
This dependency is purely internal for our UX Vue tests suite, so it's fine it won't have any impacts on dist/* files.
You can ignore Fabbot checks
@vitejs/plugin-vue
esbuild 0.21.5 require by vite 5.4.19, require by plugin-vue 4.6.2 contain security vulnerabilities It's necessary to upgrade to esbuild 0.25.0+, so plugin-vue must be in 5.1.5+ in order to have vite 6+
@vitejs/plugin-vue@vitejs/plugin-vue
|
Thank you @neothone. |
esbuild 0.21.5 require by vite 5.4.19, require by plugin-vue 4.6.2 contains security vulnerabilities
It's necessary to upgrade to esbuild to 0.25.0+, so plugin-vue must be in 5.1.5+ in order to have vite 6+ which is the first version that require esbuild 0.25.0+
It's a recurring dependabot alerts for me, example : https://github.com/fastfony/fastfony/security/dependabot/1
I have tested this upgrade on Fastfony with a fork of ux-vue repo and seems to no BC appears.