Skip to content

[Vue] Update dev dependency @vitejs/plugin-vue - #2977

Merged
Kocal merged 1 commit into
symfony:2.xfrom
neothone:patch-1
Aug 7, 2025
Merged

Kocal merged 1 commit into
symfony:2.xfrom
neothone:patch-1

Conversation

@neothone

@neothone neothone commented Aug 5, 2025

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? no
Docs? no
Issues no
License MIT

esbuild 0.21.5 require by vite 5.4.19, require by plugin-vue 4.6.2 contains security vulnerabilities

It's necessary to upgrade to esbuild to 0.25.0+, so plugin-vue must be in 5.1.5+ in order to have vite 6+ which is the first version that require esbuild 0.25.0+

It's a recurring dependabot alerts for me, example : https://github.com/fastfony/fastfony/security/dependabot/1

Capture d’écran 2025-08-06 à 00 03 48

I have tested this upgrade on Fastfony with a fork of ux-vue repo and seems to no BC appears.

Copilot AI review requested due to automatic review settings August 5, 2025 23:04
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 5, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @vitejs/plugin-vue dependency to address security vulnerabilities in the esbuild dependency chain. The change upgrades the plugin from version ^4.4.0 to ^5.1.5 to ensure compatibility with Vite 6+ which requires esbuild 0.25.0+ to resolve known security issues.

  • Updates @vitejs/plugin-vue from ^4.4.0 to ^5.1.5 in package.json

Comment thread src/Vue/assets/package.json Outdated
"@testing-library/user-event": "^14.6.1",
"@types/webpack-env": "^1.16",
"@vitejs/plugin-vue": "^4.4.0",
"@vitejs/plugin-vue": "^5.1.5",

Copilot AI Aug 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major version upgrade (4.x to 5.x) that may introduce breaking changes. Consider reviewing the plugin-vue migration guide and testing thoroughly to ensure compatibility with existing Vue components and build configurations.

Copilot uses AI. Check for mistakes.

@Kocal Kocal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This dependency is purely internal for our UX Vue tests suite, so it's fine it won't have any impacts on dist/* files.

You can ignore Fabbot checks

Comment thread src/Vue/assets/package.json Resolved
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 6, 2025
@Kocal Kocal added the Vue label Aug 6, 2025
@carsonbot carsonbot changed the title Update plugin-vue required version in package.json [Vue] Update plugin-vue required version in package.json Aug 6, 2025
@Kocal Kocal changed the title [Vue] Update plugin-vue required version in package.json [Vue] Update @vitejs/plugin-vue Aug 6, 2025
esbuild 0.21.5 require by vite 5.4.19, require by plugin-vue 4.6.2 contain security vulnerabilities

It's necessary to upgrade to esbuild 0.25.0+, so plugin-vue must be in 5.1.5+ in order to have vite 6+
@Kocal Kocal changed the title [Vue] Update @vitejs/plugin-vue [Vue] Update dev dependency @vitejs/plugin-vue Aug 7, 2025
@Kocal

Kocal commented Aug 7, 2025

Copy link
Copy Markdown
Member

Thank you @neothone.

@Kocal
Kocal merged commit 352953d into symfony:2.x Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Reviewed Has been reviewed by a maintainer Vue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants