Skip to content

[TwigComponent] Replace Twig comments with PHP comments #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
+4 −4
Merged

[TwigComponent] Replace Twig comments with PHP comments #3037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/TwigComponent/doc/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,8 +477,8 @@ The following code won't work as expected::

public function mount(): void
{
{# ❌ this won't work: at this point $type still has its default value.
Passed values are not yet available in props. #}
// ❌ this won't work: at this point $type still has its default value.
// Passed values are not yet available in props.
if ('error' === $this->type) {
// ...
}
Expand All @@ -493,8 +493,8 @@ untyped and has no default). If you need a prop's value, declare a parameter in

public function mount(string $type): void
{
{# ✅ this works as expected: the $type argument in PHP has the value
passed to the 'type' prop in the Twig template #}
// ✅ this works as expected: the $type argument in PHP has the value
// passed to the 'type' prop in the Twig template
if ('error' === $type) {
// ...
}
Expand Down