[TwigComponent][UX3] Remove deprecations #3040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
smnandre
changed the title
Kocal
approved these changes
Aug 22, 2025
carsonbot
added
Status: Reviewed
|
Need rebase |
smnandre
force-pushed
the
ux3/twig-deprecations
branch
from
ae24685 to
1491ace
Compare
|
Good. Let's deal with 8.5 in another PR |
|
Failing checks for 8.5 were fixed in 2.x |
Kocal
force-pushed
the
ux3/twig-deprecations
branch
from
1491ace to
4daa323
Compare
|
Thank you @smnandre. |
Kocal
reviewed
Aug 30, 2025
Comment on lines
-54
to
-60
| // since twig/twig 3.9.0: Using the internal "twig_to_array" function is deprecated. | ||
| if (method_exists(CoreExtension::class, 'toArray')) { | ||
| $twig_to_array = 'Twig\Extension\CoreExtension::toArray'; | ||
| } else { | ||
| $twig_to_array = 'twig_to_array'; | ||
| } | ||
|
|
Kocal
reviewed
Aug 30, 2025
Comment on lines
-63
to
-66
| if (null === $value) { | ||
| trigger_deprecation('symfony/ux-twig-component', '2.8.0', 'Passing "null" as an attribute value is deprecated and will throw an exception in 3.0.'); | ||
| $value = true; | ||
| } |
There was a problem hiding this comment.
This should have been in 2.8.0 changelog :s
Kocal
added a commit
that referenced
this pull request
Sep 25, 2025
…e (Kocal) This PR was merged into the 3.x branch. Discussion ---------- [TwigComponent] Remove dev-dependency on WebpackEncoreBundle | Q | A | -------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Documentation? | no <!-- required for new features, or documentation updates --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Follow #3040 Commits ------- e86572d [TwigComponent] Remove dev-dependency on WebpackEncoreBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.