Skip to content

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Aug 21, 2025

Q A
Bug fix? no
New feature? yes
Docs? no
Issues Fix #
License MIT

@smnandre smnandre added this to the 3.0 milestone Aug 21, 2025
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 21, 2025
@carsonbot carsonbot changed the title [UX3] Remove TwigComponent deprecations [TwigComponent][UX3] Remove TwigComponent deprecations Aug 21, 2025
@smnandre smnandre requested a review from Kocal August 21, 2025 21:15
@smnandre smnandre changed the title [TwigComponent][UX3] Remove TwigComponent deprecations [TwigComponent][UX3] Remove deprecations Aug 21, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 22, 2025
@Kocal
Copy link
Member

Kocal commented Aug 28, 2025

Need rebase

@smnandre smnandre force-pushed the ux3/twig-deprecations branch from ae24685 to 1491ace Compare August 28, 2025 22:31
@smnandre
Copy link
Member Author

Good. Let's deal with 8.5 in another PR

@Kocal
Copy link
Member

Kocal commented Aug 30, 2025

Failing checks for 8.5 were fixed in 2.x

@Kocal Kocal added the Feature New Feature label Aug 30, 2025
@Kocal Kocal force-pushed the ux3/twig-deprecations branch from 1491ace to 4daa323 Compare August 30, 2025 05:58
@Kocal
Copy link
Member

Kocal commented Aug 30, 2025

Thank you @smnandre.

@Kocal Kocal merged commit d07eef3 into symfony:3.x Aug 30, 2025
23 of 25 checks passed
Comment on lines -54 to -60
// since twig/twig 3.9.0: Using the internal "twig_to_array" function is deprecated.
if (method_exists(CoreExtension::class, 'toArray')) {
$twig_to_array = 'Twig\Extension\CoreExtension::toArray';
} else {
$twig_to_array = 'twig_to_array';
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could backport this

Comment on lines -63 to -66
if (null === $value) {
trigger_deprecation('symfony/ux-twig-component', '2.8.0', 'Passing "null" as an attribute value is deprecated and will throw an exception in 3.0.');
$value = true;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been in 2.8.0 changelog :s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants