[Icons] Fallback to default dimensions 16/16 when Icon's dimensions on Iconify are missing #3042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do agree with your messages (here and in the og issue), less so for the "bug" term but nervermind 😄 Thank you for taking the time to open a PR ! |
smnandre
approved these changes
Aug 23, 2025
carsonbot
added
Status: Reviewed
Kocal
force-pushed
the
fix-icon-viewbox
branch
from
970a992 to
8847799
Compare
Kocal
changed the title
Kocal
force-pushed
the
fix-icon-viewbox
branch
2 times, most recently
from
62bfec7 to
00d82ed
Compare
Kocal
force-pushed
the
fix-icon-viewbox
branch
from
00d82ed to
5945959
Compare
|
I just did some modifications for adding private const and to ensure a default value is set even if only one of the width or height is null |
|
Thanks @stlgaits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default viewBox size to 0 0 16 16 when not specified in Iconify icon set as per their documentation specifies : https://iconify.design/docs/types/iconify-json.html#icon to avoid exception being thrown when rendering via ux_icon() or <twig:ux:icon />