Skip to content

Conversation

javiereguiluz
Copy link
Member

Q A
Bug fix? no
New feature? no
Docs? no
Issues -
License MIT

This PR proposes:

  • To demote the installation of http-client. Showing it at the beginning of the doc creates unnecessary friction. Better explain it later when it's relaly needed.
  • Promote the installation of ux-twig-component when using the HTML syntax. It was included in a tip, but now it's shown first and more prominently to avoid user frustation.
  • Other minor tweaks

@javiereguiluz javiereguiluz added Documentation Improvements or additions to documentation Icons labels Sep 2, 2025
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Sep 2, 2025
@carsonbot carsonbot changed the title [Doc] Updates for UX Icons docs [Icons][Doc] Updates for UX Icons docs Sep 2, 2025
@Kocal Kocal requested review from kbond and smnandre September 2, 2025 16:36
@Kocal
Copy link
Member

Kocal commented Sep 2, 2025

Thanks for the suggestions!

I added Kevin and Simon as reviewers because the installation of symfony/http-client subject that recurs legit every month (😅), and I know they have some opinions on that.

The rest is fine for me

Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @javiereguiluz, we have better exception messages when http-client is missing, so I think this is perfect now!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 8, 2025
@kbond
Copy link
Member

kbond commented Sep 8, 2025

Thank you Javier.

@kbond kbond merged commit eeb13e1 into symfony:2.x Sep 8, 2025
2 checks passed
@javiereguiluz javiereguiluz deleted the icon_docs branch September 8, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Icons Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants