Skip to content

Conversation

quentinRogeret34
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Deprecations? no
Documentation? yes
Issues
License MIT

This PR fixes a typo in the documentation.

Changed:

For AssetMapper 6.3 only, you also need a ``{{ ux_controller_link_tags() }`

to

For AssetMapper 6.3 only, you also need a ``{{ ux_controller_link_tags() }}``

Asset Mapper 6.3 example is missing a }
@carsonbot carsonbot added Documentation Improvements or additions to documentation Status: Needs Review Needs to be reviewed labels Sep 24, 2025
@carsonbot carsonbot changed the title Docs: fix missing backtick in AssetMapper 6.3 example Docs: fix missing backtick in AssetMapper 6.3 example Sep 24, 2025
@smnandre smnandre changed the title Docs: fix missing backtick in AssetMapper 6.3 example [StimulusBundle] Add missing backtick in AssetMapper 6.3 example Sep 24, 2025
@smnandre
Copy link
Member

Thanks!

Wondering if we should not remove this mention entirely ? Symfony 6.3 is not maintained anymore and i'm not sure this is usefull for anyone, but it adds "noise" for the other readers.. wdyt ?

cc @Kocal

@smnandre smnandre changed the title [StimulusBundle] Add missing backtick in AssetMapper 6.3 example [StimulusBundle] Add missing closing brace in AssetMapper 6.3 example Sep 24, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 24, 2025
@quentinRogeret34
Copy link
Contributor Author

You're right, it does seem very tied to a specific version that shouldn’t be used anymore 🤔
I can update my PR to remove this block if that makes more sense

@Kocal
Copy link
Member

Kocal commented Sep 24, 2025

I suggest to keep it since we still maintain support for Symfony ^6.3.

However in UX 3.0, we can remove the doc block and the ux_controller_link_tags() Twig function (that is already deprecated)

@Kocal
Copy link
Member

Kocal commented Sep 30, 2025

Thank you @quentinRogeret34.

@Kocal Kocal merged commit 20f4e12 into symfony:2.x Sep 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Status: Reviewed Has been reviewed by a maintainer StimulusBundle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants