Repository navigation
[StimulusBundle] Add missing closing brace in AssetMapper 6.3 example - #3096
Merged
Merged
Conversation
Asset Mapper 6.3 example is missing a }
Member
|
Thanks! Wondering if we should not remove this mention entirely ? Symfony 6.3 is not maintained anymore and i'm not sure this is usefull for anyone, but it adds "noise" for the other readers.. wdyt ? cc @Kocal |
smnandre
approved these changes
Sep 24, 2025
Contributor
Author
|
You're right, it does seem very tied to a specific version that shouldn’t be used anymore 🤔 |
Member
|
I suggest to keep it since we still maintain support for Symfony ^6.3. However in UX 3.0, we can remove the doc block and the |
smnandre
approved these changes
Sep 28, 2025
Member
|
Thank you @quentinRogeret34. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in the documentation.
Changed:
For AssetMapper 6.3 only, you also need a ``{{ ux_controller_link_tags() }`to
For AssetMapper 6.3 only, you also need a ``{{ ux_controller_link_tags() }}``