Skip to content

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Sep 24, 2025

Q A
Bug fix? no
New feature? yes
Deprecations? no
Documentation? no
Issues Fix #...
License MIT

Remove this check (or same-ish) in these ux pacakges

        if ($stimulus instanceof StimulusTwigExtension) {
            trigger_deprecation('symfony/ux-chartjs', '2.9', 'Passing an instance of "%s" to "%s" is deprecated, pass an instance of "%s" instead.', StimulusTwigExtension::class, __CLASS__, StimulusHelper::class);
            $stimulus = new StimulusHelper(null);
        }

@smnandre smnandre added this to the 3.0 milestone Sep 24, 2025
@carsonbot carsonbot changed the title [ChartJs][Notify][React][Svelte] Remove StimulusHelper deprecation for 3.0 [Chartjs][Notify][React][Svelte] Remove StimulusHelper deprecation for 3.0 Sep 24, 2025
@Kocal Kocal added the Feature New Feature label Sep 25, 2025
@Kocal Kocal force-pushed the remove-deprecation-react-svelte-notify-chart branch from 2f0f4b7 to 4601ec3 Compare September 25, 2025 06:41
@Kocal Kocal force-pushed the remove-deprecation-react-svelte-notify-chart branch from 4601ec3 to 3db76d1 Compare September 25, 2025 06:45
@Kocal
Copy link
Member

Kocal commented Sep 25, 2025

Thank you @smnandre.

@Kocal Kocal merged commit a4bd38f into symfony:3.x Sep 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants