[LiveComponent] Fix svg re-render #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
norkunas
commented
Nov 17, 2022
norkunas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Tickets | #556 |
| License | MIT |
|
Thanks for the reproducer test - super useful. I can't think, immediately, what the problem might be - maybe something in morphdom? Unless someone beats me to it (which would be great!) I'll check it out when I have some time. |
|
Thought about morphdom too, but they have svg tests,so not sure how this could happen currently.. |
norkunas
force-pushed
the
svg
branch
3 times, most recently
from
a1e6ba9 to
dbc93e8
Compare
norkunas
changed the title
|
Found the root cause and added a fix. |
weaverryan
reviewed
Nov 28, 2022
| if ( | ||
| !(fromEl instanceof HTMLElement || fromEl instanceof SVGElement) || | ||
| !(toEl instanceof HTMLElement || toEl instanceof SVGElement) | ||
| ) { |
There was a problem hiding this comment.
Nice find. SVG's not being part of HTMLElement is such a pain in the butt :). Thanks for the test case to prevent it from slipping through in the future.
|
Thanks Tomas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.