Making all events bubble - affects Chartjs, Cropperjs, Dropzone, LazyImage, Swup #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just interested: why not using |
kbond
changed the title
|
Lol, good question. Two reasons: 1) Until about a week ago I didn't know this existed! And, related, (2), this |
weaverryan
force-pushed
the
events-bubble
branch
from
153c521 to
0923674
Compare
|
This is now ready for a quick look-over - all of the new ways to dispatch the events should result in the same event name & target as before, unless I've done something silly or copy-pasta'ed something poorly. |
weaverryan
force-pushed
the
events-bubble
branch
from
0923674 to
f122dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long-overdue fix for #30. This is a small behavior change, but I consider it a bug fix. The only way that you could be affected by this change in practice is if you have one of the UX components listed inside of itself - e.g. a chart inside a chart, so now the existing listener on the outer chart is fired twice. But I don't think that makes any practical sense for any of these components.
Cheers!