Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: style-loader version 1.X #710

Merged
merged 1 commit into from Mar 27, 2020
Merged

Conversation

@Grafikart
Copy link
Contributor

Grafikart commented Mar 16, 2020

The webpack encore version style loader is too old and inject CSS using <link> instead of <style>. This solution loads style asynchronously cause lots of problem with JavaScript.

With this upgrade style-loader doesn't accept sourcemap anymore. SourceMap support is calculated from previous loaders (https://github.com/webpack-contrib/style-loader#source-maps)

@Kocal
Kocal approved these changes Mar 16, 2020
Copy link
Member

weaverryan left a comment

This makes sense to me. @Lyrkan do you see any issues?

@Lyrkan

This comment has been minimized.

Copy link
Collaborator

Lyrkan commented Mar 20, 2020

This makes sense to me. @Lyrkan do you see any issues?

@weaverryan Can't see any, it's probably one of the things we never updated ^^'
Breaking changes are listed there: https://github.com/webpack-contrib/style-loader/releases/tag/v1.0.0

@Lyrkan
Lyrkan approved these changes Mar 20, 2020
@weaverryan

This comment has been minimized.

Copy link
Member

weaverryan commented Mar 27, 2020

Thank you Jonathan!

@weaverryan weaverryan merged commit fd93a4e into symfony:master Mar 27, 2020
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.