add svelte support to webpack encore #781
Conversation
| @@ -399,6 +399,17 @@ class ConfigGenerator { | |||
| })); | |||
| } | |||
|
|
|||
| if (this.webpackConfig.useSvelte) { | |||
| rules.push(applyRuleConfigurationCallback('svelte', { | |||
There was a problem hiding this comment.
The following documentation https://symfony.com/doc/current/frontend/encore/advanced-config.html#having-the-full-control-on-loaders-rules will need to be updated.
There was a problem hiding this comment.
yes after the merge :)
This comment has been minimized.
This comment has been minimized.
|
Hey @zairigimad! Do you need a hand with that PR? It would be great to have Svelte's support in webpack encore. If I can help in any way, let me know! |
|
@Volubyl yes it will be great if you can help :) |
Nice! Can you tell me what remains to be done with this PR and how I can help? |
when I've added this, it was working, maybe if you can test it and see if something missing or if you have and idea you can add it :) |
There was a problem hiding this comment.
Sorry for letting this sit for SO long without any attention :/.
The only thing I can see that this is missing is a test in functional.js. It would probably include adding a "hello world" type of svelte file into the fixtures, then booting up an Encore setup, executing Encore and asserting that the result works. We have plenty of examples of that sort of thing in that functional.js file - React or Vue might be especially good examples to pull from.
Cheers!
no problem, I will make the test ASAP. |
zairigimad
force-pushed
the
feature/add-SvelteJs-Support
branch
from
1297d29
to
b7c9b74
Compare
|
Hey @weaverryan I've added the functional test for svelte :) |
zairigimad
force-pushed
the
feature/add-SvelteJs-Support
branch
from
7d51db5
to
5f749aa
Compare
|
Any chances to be merged in near future? |
weaverryan
force-pushed
the
feature/add-SvelteJs-Support
branch
from
5f749aa
to
9f6056b
Compare
|
Thank you @zairigimad! I'm so sorry - and embarrassed by how much this fell off my radar. Apologies for the insane delay, but this is excellent work! |
No problem you are doing an incredible work maintaining lot of things in Symfony ecosystem, thanks to you. I’m very happy that it’s finally merged 🎉 |
…rryan) This PR was submitted for the 6.1 branch but it was merged into the 4.4 branch instead. Discussion ---------- Mentioning svelte as a valid loader override type Hi! Minor tweak for symfony/webpack-encore#781 We could also document svelte itself, though there is also a proposed UX svelte component which, if merged, would be an even better option (and it would leverage this new feature in Encore). Cheers! Commits ------- 7f3a21d Mentioning svelte as aa valid loader override type
The goal of this PR is to add support of Svelte to Webpack Encore.