Add French translations for the exceptions #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bocharsky-bw
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Thank you for adding missing translations for French! I'm fine to start with email. Anyway, it's possible to easily override translations for users.
Keep in mind that the reason translations will work out of the box in the new make:reset-password generated code and only after symfony/maker-bundle#1059 is merged. But you can just wrap the reasons with trans() in your project yourself for now, just steal the actual implementation from symfony/maker-bundle#1059
jrushlow
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Awesome! Thanks for the help with these translations @DennisdeBest
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just saw that the translations have been added for the exceptions, that is awesome thanks.
I have added the translations for French. The one thing people might disagree over is keeping the word
email, depending on who you talk to they can prefer,courriel,courrier-électronique,Mel, ...