Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the target frame and reference frame for TorqueActuator #25333

Closed
wants to merge 1 commit into from

Conversation

kaustubh-765
Copy link
Contributor

@kaustubh-765 kaustubh-765 commented Jul 7, 2023

Updated the frame in TorqueActuator

References to other Issues or PRs

"Fixes #25319"

Brief description of what is fixed or changed

The frame of reference is updated, where the child frame is made the target frame and the parent frame is made the reference frame. This leads to positive value calculation of the torque.

 TorqueActuator.at_pin_joint 

is updated.

and the test case is updates to

assert instance.target_frame == self.A
assert instance.reaction_frame == self.N

Other comments

Kindly review the changes.

Release Notes

  • solvers

    • Updated the frame for target and reference frame
  • physics.mechanics

    • Fixed the bug with Parent and Child frame as Reference and Target frame TorqueActuator(T, axis=N.z, target_frame=N, reaction_frame=A) to TorqueActuator(T, axis=N.z, target_frame=A, reaction_frame=N)

@sympy-bot
Copy link

sympy-bot commented Jul 7, 2023

Hi, I am the SymPy bot (v170). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • physics.mechanics

    • Fixed the bug with Parent and Child frame as Reference and Target frame TorqueActuator(T, axis=N.z, target_frame=N, reaction_frame=A) to TorqueActuator(T, axis=N.z, target_frame=A, reaction_frame=N) (#25333 by @kaustubh-765)
  • solvers

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->
Updated the frame in TorqueActuator

#### References to other Issues or PRs
"Fixes #25319"
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
The frame of reference is updated, where the child frame is made the target frame and the parent frame is made the reference frame. This leads to positive value calculation of the torque.

``` 
 TorqueActuator.at_pin_joint 
```

is updated. 

and the test case is updates to 

```
assert instance.target_frame == self.A
```

```
assert instance.reaction_frame == self.N
```

#### Other comments
Kindly review the changes. 

#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers. Formerly, `log(-x)` incorrectly gave `-log(x)`.

* physics.units
  * Corrected a semantical error in the conversion between volt and statvolt which
    reported the volt as being larger than the statvolt.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* solvers
  * Updated the frame for target and reference frame

* physics.mechanics 
  * Fixed the bug with Parent and Child frame as Reference and Target frame `TorqueActuator(T, axis=N.z, target_frame=N, reaction_frame=A)` to `TorqueActuator(T, axis=N.z, target_frame=A, reaction_frame=N)`

<!-- END RELEASE NOTES -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TorqueActuator.at_pin_joint has counter intuitive directions
2 participants