Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons don't match the overall L&F #459

Closed
memeplex opened this issue Jun 13, 2018 · 6 comments
Closed

Some icons don't match the overall L&F #459

memeplex opened this issue Jun 13, 2018 · 6 comments

Comments

@memeplex
Copy link

memeplex commented Jun 13, 2018

The menu has some coloured icons (settings, shutdown, show id) that don't play well with the rest of the icons and also modern gnome/gtk design. There is a lot of high quality svg icons in https://github.com/PapirusDevelopmentTeam/papirus-icon-theme to pick from.

@memeplex
Copy link
Author

Also "Edit ignore patterns".

@memeplex
Copy link
Author

Some suggestions:

  • settings -> Papirus/16x16/actions/settings.svg
  • shutdown -> Papirus-Adapta/16x16/panel/system-shutdown-panel.svg
  • edit ignore patterns -> Papirus/16x16/actions/image-red-eye.svg

The last one is not an eye but a crossed eye, which I think is more meaningful because these are patterns to ignore (not look at).

@kozec
Copy link
Owner

kozec commented Jun 13, 2018

Both settings and shutdown are taken from theme, but "edit ignore patterns" isn't. I'll have to check if GPL3 icon can be used with GPL2 program.

@memeplex
Copy link
Author

memeplex commented Jun 14, 2018 via email

@kozec
Copy link
Owner

kozec commented Jun 14, 2018

preferences-system and system-shutdown. Maybe your theme doesn't include them and so fallbacks from Adwaita are used?

@kozec
Copy link
Owner

kozec commented Sep 22, 2018

Sorry, but I found this to be surprisingly hard change and potential licence mess, so I decided that current icons are fine :)

@kozec kozec closed this as completed Sep 22, 2018
@kozec kozec added the wontfix label Sep 22, 2018
Repository owner locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants