Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for adjacent matches in the same text node #4

Merged

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Sep 12, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Add a unit test to check that multiple matches in the same text node are replaced.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 12, 2023
@lpsinger lpsinger force-pushed the test-multiple-occurrences-in-same-node branch from b7177ee to 0e5cafa Compare September 12, 2023 13:45
@lpsinger
Copy link
Contributor Author

#5 was user error on my part, not a bug. But here's an additional unit test if you want it.

@wooorm wooorm changed the title Add unit test for multiple occurrences in the same node Add unit test for adjacent matches in the same text node Sep 12, 2023
@wooorm wooorm merged commit fbe1d6b into syntax-tree:main Sep 12, 2023
3 checks passed
@wooorm wooorm added 🕸️ area/tests This affects tests 💪 phase/solved Post is done labels Sep 12, 2023
@wooorm
Copy link
Member

wooorm commented Sep 12, 2023

thanks! :)

@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Sep 12, 2023
@lpsinger lpsinger deleted the test-multiple-occurrences-in-same-node branch September 12, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕸️ area/tests This affects tests 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants