Skip to content

Change signature to use node first, test second #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2019
Merged

Change signature to use node first, test second #8

merged 1 commit into from
May 31, 2019

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented May 29, 2019

Closes GH-6.

Still not 100% sure if this is a great idea, see #6 (comment).

@wooorm wooorm merged commit e5388f7 into master May 31, 2019
@wooorm wooorm deleted the node-first branch May 31, 2019 06:35
@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Aug 12, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees

No one assigned

Labels

🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node first, test second

2 participants

@wooorm @ChristianMurphy