Adds fix for app name inside GetPlayerAchievements() #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$app->first()->name may cause an additional "Trying to get property of non-object" exception if the app is not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced function:
GetPlayerAchievements()$appName = str_replace(' ', '', $app->first()->name);caused several "Trying to get property of non-object" exceptions while running the function for hundreds of games. I didn't investigated why$appwas empty but it was so this is just a small hotfix.The exceptions can be reproduced with the Steam App ID
219540(Arma 2: Operation Arrowhead Beta (Obsolete)).