-
Notifications
You must be signed in to change notification settings - Fork 0
Feat improved testcase readability #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6233593179
💛 - Coveralls |
mitchellolsthoorn
requested changes
Sep 19, 2023
libraries/analysis-javascript/lib/type/discovery/element/ElementVisitor.ts
Show resolved
Hide resolved
libraries/search-javascript/lib/testbuilding/JavaScriptDecoder.ts
Outdated
Show resolved
Hide resolved
mitchellolsthoorn
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also found a bug:
The require function caches contents of files. So when we require a "constant object" from a file multiple times we are actually using the same instance. During the search process this is no problem since all tests are ran in isolation. However, the final test suite puts all the tests in the same file so the results where not consistent.
I fixed this by removing cached files in the beforeEach method of mocha.