Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair decoder undefined json bug #210

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

dstallenberg
Copy link
Contributor

@dstallenberg dstallenberg commented Dec 11, 2023

When the stringified json contains a undefined or NaN value we need to replace it by null to allow for json.parse to work.
Previously we used a simple replace. Now its a regex that only replaces unquoted instances of undefined & NaN.

@dstallenberg dstallenberg requested a review from a team as a code owner December 11, 2023 12:08
@coveralls
Copy link
Collaborator

coveralls commented Dec 11, 2023

Pull Request Test Coverage Report for Build 7167270278

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.9%

Totals Coverage Status
Change from base Build 7166447209: 0.0%
Covered Lines: 1544
Relevant Lines: 3042

💛 - Coveralls

@dstallenberg dstallenberg merged commit f3cd2e7 into main Dec 11, 2023
12 checks passed
@dstallenberg dstallenberg deleted the fix-decorder-undefined-json-bug branch December 11, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants