-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI action workflows for testing and building #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Still not sure about this pre-commit stuff, if we're going to use mypy properly I think we have to use it explicitly
8784e11
to
3d08168
Compare
3d08168
to
cb81fd1
Compare
6f05db3
to
234c114
Compare
ef7de6a
to
793a124
Compare
793a124
to
d828390
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright I think this should be pretty good now. I've found an even faster way and simpler way to run the pre-commit in CI and it's free so we're saving a few $ too 🎉
The End of line fixer and trailing whitespace marks also commits straight to the PR branch which is quite nice.
I've also updated the mypy config so that we are explicitly stating the packages which we are not type checking for clarity.
It looks like its now picking up the typing errors too (hopefully they're the ones you mentioned!)
@jamied157 let me know what you think!
Kudos, SonarCloud Quality Gate passed! |
Prior CI Workflow:
New CI Workflow: