Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI action workflows for testing and building #21

Merged
merged 16 commits into from
Aug 27, 2021
Merged

Conversation

simonhkswan
Copy link
Contributor

@simonhkswan simonhkswan commented Aug 22, 2021

Prior CI Workflow:

  • Lint (custom flake8/mypy)
    • Test
      • Sonar Cloud

New CI Workflow:

  • Lint (using pre-commit.ci which is free). This also autofixes whitespaces etc.
  • Test (with coverage)
    • Sonar Cloud

@simonhkswan simonhkswan added the pr:devops Continuous Integration and Packaging label Aug 22, 2021
@simonhkswan simonhkswan self-assigned this Aug 22, 2021
@simonhkswan simonhkswan linked an issue Aug 22, 2021 that may be closed by this pull request
4 tasks
@simonhkswan simonhkswan requested a review from jamied157 August 22, 2021 19:24
Copy link
Contributor

@jamied157 jamied157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Still not sure about this pre-commit stuff, if we're going to use mypy properly I think we have to use it explicitly

@simonhkswan simonhkswan force-pushed the ci-actions branch 4 times, most recently from 8784e11 to 3d08168 Compare August 24, 2021 14:35
@simonhkswan simonhkswan force-pushed the ci-actions branch 5 times, most recently from 6f05db3 to 234c114 Compare August 24, 2021 20:23
@simonhkswan simonhkswan force-pushed the ci-actions branch 5 times, most recently from ef7de6a to 793a124 Compare August 24, 2021 21:12
Copy link
Contributor Author

@simonhkswan simonhkswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I think this should be pretty good now. I've found an even faster way and simpler way to run the pre-commit in CI and it's free so we're saving a few $ too 🎉

The End of line fixer and trailing whitespace marks also commits straight to the PR branch which is quite nice.

I've also updated the mypy config so that we are explicitly stating the packages which we are not type checking for clarity.

It looks like its now picking up the typing errors too (hopefully they're the ones you mentioned!)

@jamied157 let me know what you think!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@simonhkswan simonhkswan requested review from a team and jamied157 and removed request for jamied157 August 24, 2021 22:49
@simonhkswan simonhkswan merged commit b35fa4d into master Aug 27, 2021
@simonhkswan simonhkswan deleted the ci-actions branch August 27, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:devops Continuous Integration and Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting up CI + Packaging
2 participants