Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-physical behavior near zero copy number for SSA #215

Closed
0u812 opened this issue Oct 11, 2015 · 5 comments
Closed

Non-physical behavior near zero copy number for SSA #215

0u812 opened this issue Oct 11, 2015 · 5 comments
Assignees

Comments

@0u812
Copy link
Member

0u812 commented Oct 11, 2015

The Gillespie simulator allows the copy numbers of molecules to go negative, which should not happen.

@0u812 0u812 self-assigned this Oct 11, 2015
@luciansmith
Copy link

There's no reason to require species to not go negative in the simulator,
since some models are modelling things that can actually go negative like
charge or debt. A warning is probably appropriate, though.
On Oct 11, 2015 9:36 AM, "Kyle Medley" notifications@github.com wrote:

The Gillespie simulator allows the copy numbers of molecules to go
negative, which should not happen.


Reply to this email directly or view it on GitHub
#215.

@0u812
Copy link
Member Author

0u812 commented Oct 11, 2015

True, but some models like the Mycoplasma whole-cell model apparently rely on the simulation algorithm stopping reactions before the copy number can go negative, so I'll put it behind a config flag.

@hsauro
Copy link

hsauro commented Oct 11, 2015

In that case its a bad model. The biophysics should be correct so that
concentration will naturally not go negative. It means the model is not a
good physical representation.

H

On Sun, Oct 11, 2015 at 9:48 AM, Kyle Medley notifications@github.com
wrote:

True, but some models like the Mycoplasma whole-cell model apparently rely
on the simulation algorithm stopping reactions before the copy number can
go negative, so I'll put it behind a config flag.


Reply to this email directly or view it on GitHub
#215 (comment).

@0u812
Copy link
Member Author

0u812 commented Oct 11, 2015

Fixed. Python syntax is:

r.setIntegrator('gillespie')
r.getIntegrator().setValue('nonnegative', True)

@0u812 0u812 closed this as completed in 8a50677 Oct 11, 2015
@luciansmith
Copy link

I have to agree that that is a crappy model, and not an issue with the
simulator. And in fact, I'm not convinced that adding a special option
that makes the simulator behave incorrectly in response is a good solution,
as the model will continue to be unexchangeable, and exchangeability is
kind of the whole point of SBML, etc.

However, I could see a translator from that crappy model to a slightly
better (but still unrealistic) model that converted reaction rates from:

f(x,y)

to:

piecewise(0, S1<=0, f(x,y))

-Lucian

On Sun, Oct 11, 2015 at 10:26 AM, Kyle Medley notifications@github.com
wrote:

Closed #215 #215 via 8a50677
8a50677
.


Reply to this email directly or view it on GitHub
#215 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants