Skip to content

chore: upgrade cli scanner to 1.22.1 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

chore: upgrade cli scanner to 1.22.1 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/infra/scanner_binary_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pub(super) struct ScannerBinaryManager {}

impl ScannerBinaryManager {
const fn version(&self) -> Version {
Version::new(1, 20, 0)
Version::new(1, 22, 1)
}

pub async fn install_expected_version_if_not_present(
Expand Down Expand Up @@ -194,16 +194,16 @@ mod tests {
async fn it_gets_the_wanted_version() {
let mgr = ScannerBinaryManager::default();

assert_eq!(mgr.version().to_string(), "1.20.0");
assert_eq!(mgr.version().to_string(), "1.22.1");
}

#[tokio::test]
async fn it_retrieves_the_binary_path() {
let mgr = ScannerBinaryManager::default();

assert!(
mgr.binary_path_for_version(&Version::new(1, 20, 0))
.ends_with(".cache/sysdig-cli-scanner/sysdig-cli-scanner.1.20.0")
mgr.binary_path_for_version(&Version::new(1, 22, 1))
.ends_with(".cache/sysdig-cli-scanner/sysdig-cli-scanner.1.22.1")
);
}

Expand All @@ -212,8 +212,8 @@ mod tests {
let mgr = ScannerBinaryManager::default();

assert_eq!(
mgr.download_url(&Version::new(1, 20, 0)).unwrap(),
"https://download.sysdig.com/scanning/bin/sysdig-cli-scanner/1.20.0/linux/amd64/sysdig-cli-scanner"
mgr.download_url(&Version::new(1, 22, 1)).unwrap(),
"https://download.sysdig.com/scanning/bin/sysdig-cli-scanner/1.22.1/linux/amd64/sysdig-cli-scanner"
);
}

Expand All @@ -234,7 +234,7 @@ mod tests {
.await
.unwrap()
.to_string(),
"1.20.0"
"1.22.1"
);
}

Expand All @@ -257,7 +257,7 @@ mod tests {
.await
.unwrap()
.to_string(),
"1.20.0"
"1.22.1"
);
}
}
2 changes: 1 addition & 1 deletion tests/fixtures/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ RUN apk update

RUN apk add curl

RUN curl -L https://ftp.belnet.be/mirror/jenkins/war/2.455/jenkins.war -o /jenkins.war
RUN curl -L https://get.jenkins.io/war-stable/2.401.3/jenkins.war -o /jenkins.war

FROM nginx:latest

Expand Down