Skip to content

Allow custom CA_BUNDLE via SDC_SSL_VERIFY env #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

DaveCanHaz
Copy link
Contributor

@DaveCanHaz DaveCanHaz commented Aug 18, 2020

This will allow for a custom CA_BUNDLE to be provided via an environment variable. Prior to this change the only valid values for the SDC_SSL_VERIFY env variable were True, and anything else was evaluated to False. For example:

Prior to this change:

Value Result
SDC_SSL_VERIFY=true ssl_verify=True
SDC_SSL_VERIFY=false ssl_verify=False
SDC_SSL_VERIFY=/path/to/custom.pem ssl_verify=False

After this change implemented:

Value Result
SDC_SSL_VERIFY=true ssl_verify=True
SDC_SSL_VERIFY=false ssl_verify=False
SDC_SSL_VERIFY=/path/to/custom.pem ssl_verify=/path/to/custom.pem

@tembleking tembleking self-requested a review August 20, 2020 16:29
@tembleking
Copy link
Member

Hi @DaveCanHaz, unfortunately the tests cannot be run against PRs from forks of the project, because there's a limitation in GitHub Actions where the secrets are not transfered to the runner.

The content of the PR looks good to me tho, so I am going to merge it anyway.

Thank you for your contribution!

@tembleking tembleking merged commit 03e9bd3 into sysdiglabs:master Aug 20, 2020
@DaveCanHaz
Copy link
Contributor Author

@tembleking - Understood and Thanks! Let me know if there is a more preferred mechanism for submitting PRs / changes in the future.

Kindly, when is PyPI update expected with the latest changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants