Skip to content

fix(team): get team will fetch only from selected product #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 19, 2023
Merged

fix(team): get team will fetch only from selected product #243

merged 9 commits into from
Jun 19, 2023

Conversation

filiptubic
Copy link
Collaborator

@filiptubic filiptubic commented Jun 14, 2023 •
edited
Loading

Scope of this PR is to fix teams client when fetching all teams from Monitor/Secure.
Before this change, regardless which product you use, it will list teams from both Monitor and Secure.

New team tests are passing.

Teams
  ✓ it it should list all teams (0.9130 seconds)
  ✓ it it should list only monitor teams (1.3379 seconds)
  ✓ it it should list only secure teams (1.3811 seconds)

@filiptubic filiptubic marked this pull request as ready for review June 16, 2023 08:42
@filiptubic filiptubic requested a review from luzeno June 16, 2023 09:54
luzeno
luzeno reviewed Jun 16, 2023
View reviewed changes
luzeno
luzeno approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@luzeno luzeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filiptubic filiptubic merged commit b663d00 into master Jun 19, 2023
@filiptubic filiptubic deleted the fix-product-teams branch June 19, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luzeno luzeno luzeno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filiptubic @luzeno