Use yaml for agent config content #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set_agents_config.py/get_agents_config.py currently read and write the raw json that's inside the api body. This isn't very user friendly. Change them to work directly with the agent config-as-yaml content instead. get_agents_config.py will extract the yaml confg from the json response and print it. set_agents_config.py will take the agent config from the file on the command line, verify that it can be parsed as yaml, wrap it in json, and PUT it.
If there is no auto config, the response will have an empty list of files. Handle that and just print a message that there is no config.
|
@mstemm and I talked through some changes 1-on-1 and I'm now 👍 on this. |
That way you can tell if there's leading/trailing whitespace, or no whitespace at all.
Instead of app-staging.sysdigcloud.com.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_agents_config.py/get_agents_config.py currently read and write the
raw json that's inside the api body. This isn't very user friendly.
Change them to work directly with the agent config-as-yaml content
instead. get_agents_config.py will extract the yaml confg from the json
response and print it. set_agents_config.py will take the agent config
from the file on the command line, verify that it can be parsed as yaml,
wrap it in json, and PUT it.