Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where deleting all policies would delete all alerts too #61

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

jaykeshur
Copy link
Contributor

No description provided.

@philrz philrz requested a review from mstemm August 13, 2018 23:24
@philrz
Copy link
Contributor

philrz commented Aug 14, 2018

@jaykeshur: Thanks very much for bringing this to our attention. Now that I've reproduced the issue and confirmed that your PR works around the problem, I can say the side-effect you saw of the Alerts getting deleted from the Monitor side is not intended behavior. Therefore I've opened up a bug against the Sysdig Secure backend (SSPROD-1025) to fix the behavior of the underlying API, at which point the original Python client example that hits the /api/policies/deleteAll should be able to remain as it was.

In the meantime, I'm going to hold your PR open in case anyone else stumbles onto this. I'm anticipating I'll be able to update this and close without Merge once we've fixed the API behavior.

@davideschiera
Copy link
Contributor

@jaykeshur I'm about to merge the PR. The build failed, I'm trying to understand why, but I'll probably merge first and take it from there.

In the meanwhile, we will also apply the proper fix to the API soon. Your patch will remain useful for some time after (e.g. with an older onprem deployment).

Thanks for the help, and sorry for the delay!

@davideschiera davideschiera merged commit 6676a96 into sysdiglabs:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants